Alexey Serbin has posted comments on this change. Change subject: KUDU-1835 (part 1). Move compression codec classes to util ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5735/4/src/kudu/cfile/cfile-test.cc File src/kudu/cfile/cfile-test.cc: PS4, Line 929: for (auto codec : { NO_COMPRESSION, SNAPPY, LZ4, ZLIB }) { : SCOPED_TRACE(codec); : TestReadWriteUncompressible(codec); : } nit: consider using parameterized tests, if it makes sense. http://gerrit.cloudera.org:8080/#/c/5735/4/src/kudu/util/compression/compression-test.cc File src/kudu/util/compression/compression-test.cc: PS4, Line 20: #include <gtest/gtest.h> : #include <glog/logging.h> : #include <vector> nit: please re-order according to the style guide https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes PS4, Line 52: gscoped_array<uint8_t> cbuffer(new uint8_t[max_compressed]); nit: would std::unique_ptr<uint8_t[]> fit as well? -- To view, visit http://gerrit.cloudera.org:8080/5735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffe09aba18fd829f5918aabe061ca8b7f9d494c0 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
