Alexey Serbin has posted comments on this change. Change subject: [security] groundwork for cert signing service ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5671/5/src/kudu/security/test/cert_management-test.cc File src/kudu/security/test/cert_management-test.cc: Line 89: .hostnames = hostnames, > warning: parameter 'hostnames' is passed by value and only copied once; con Done Line 90: .ips = ips, > warning: parameter 'ips' is passed by value and only copied once; consider Done -- To view, visit http://gerrit.cloudera.org:8080/5671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2ce55d38f4d06172fadaaa702f4550997d9bc8f Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
