Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [8/n]: TLS negotiation ......................................................................
Patch Set 3: (12 comments) http://gerrit.cloudera.org:8080/#/c/5762/1/src/kudu/rpc/client_negotiation.cc File src/kudu/rpc/client_negotiation.cc: Line 95: } > error: no template named 'unique_ptr'; did you mean 'std::unique_ptr'? [cla Done http://gerrit.cloudera.org:8080/#/c/5762/1/src/kudu/rpc/client_negotiation.h File src/kudu/rpc/client_negotiation.h: Line 93: // Allow TLS to be used on the connection. 'tls_context' is borrowed, and must > ClientNegotiation Done Line 101: > error: no template named 'unique_ptr'; did you mean 'std::unique_ptr'? [cla Done http://gerrit.cloudera.org:8080/#/c/5762/1/src/kudu/rpc/messenger.h File src/kudu/rpc/messenger.h: Line 247: std::unique_ptr<security::TlsContext> tls_context_; > error: no template named 'unique_ptr'; did you mean 'std::unique_ptr'? [cla Done http://gerrit.cloudera.org:8080/#/c/5762/1/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: Line 63: struct propctx *propctx) { > error: no template named 'unique_ptr'; did you mean 'std::unique_ptr'? [cla Done Line 323: client_features_.insert(feature_flag); > error: unexpected type name 'string': expected expression [clang-diagnostic Done Line 324: } > error: use of undeclared identifier 'server_mechs' [clang-diagnostic-error] Done Line 333: RETURN_NOT_OK(SendError(ErrorStatusPB::FATAL_UNAUTHORIZED, s)); > error: use of undeclared identifier 'server_mechs' [clang-diagnostic-error] Done Line 337: RETURN_NOT_OK(SendNegotiate(server_mechs)); > error: expected ')' [clang-diagnostic-error] Done Line 341: Status ServerNegotiation::SendNegotiate(const set<string>& server_mechs) { > error: use of undeclared identifier 'server_mechs' [clang-diagnostic-error] Done http://gerrit.cloudera.org:8080/#/c/5762/1/src/kudu/rpc/server_negotiation.h File src/kudu/rpc/server_negotiation.h: Line 105: > error: no template named 'unique_ptr'; did you mean 'std::unique_ptr'? [cla Done Line 153: > warning: function 'kudu::rpc::ServerNegotiation::HandleTlsHandshake' has a Done -- To view, visit http://gerrit.cloudera.org:8080/5762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d36ed8ecf6067a3043344557f45ebd3cdcf9d Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
