Hello Dan Burkert, Alexey Serbin, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5767

to look at the new patch set (#3).

Change subject: Use Traits to avoid duplicate code in SSL wrappers
......................................................................

Use Traits to avoid duplicate code in SSL wrappers

cert_management.cc contained some duplicate code for each of the
wrappers. In addition, having to always remember the correct 'free'
function for each SSL type was a bit difficult.

This uses a "traits" pattern to try to clean up the code. It doesn't
save a ton of lines of code, but it replaces a lot of imperative code
with more "declarative" lists of types and functions.

Change-Id: If1c44857358fc82f2694dff021b9f2ac3641313a
---
M src/kudu/security/ca/cert_management.cc
1 file changed, 123 insertions(+), 136 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/5767/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If1c44857358fc82f2694dff021b9f2ac3641313a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

Reply via email to