Alexey Serbin has posted comments on this change. Change subject: [security] separated OpenSSL wrappers from CA ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5779/3/src/kudu/security/openssl_traits.h File src/kudu/security/openssl_traits.h: Line 52: template<class SSL_TYPE> > I don't feel strongly about whether they are put into openssl_util or not, This is a special case, I would say. I put those in here because they are used in openssl_util.cc and ca/cert_management.cc, and there are internal. Ideally, those should be kept in those *.cc files, but having them in both files would be code duplication. May be, I should name this as openssl_util-inl.h ? -- To view, visit http://gerrit.cloudera.org:8080/5779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37729a865739c5702e92238b9d2375f5bf71543d Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
