Todd Lipcon has posted comments on this change. Change subject: WIP [master] store CA information in the system table ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5793/2/src/kudu/master/master.proto File src/kudu/master/master.proto: PS2, Line 181: // The identifier of the entry in the system table for the certificate's : // private key. If empty, then the private key is stored along with the : // certificate data itself. : optional string private_key_id = 3; > Current code assumes we always store the key separately. The coment was ab Yea, I think given these are just internal-facing PBs, we shouldn't document "what-ifs" if they are things that don't actually happen. Line 190: message SysCAPrivateKeyEntryPB { > The idea was to support the case when we have multiple CA certs based on th Yea, that makes sense, I forgot about other metadata that you might want to store with a key such as the timestamps, etc, and the idea that the cert and key may rotate at different frequencies. -- To view, visit http://gerrit.cloudera.org:8080/5793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16fa077e39f5d75f682cca7220371acdef4f0630 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
