Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first ......................................................................
Patch Set 3: (1 comment) I'm good with the change, just one javadoc comment to fix. Thanks! http://gerrit.cloudera.org:8080/#/c/5723/3/java/kudu-client/src/main/java/org/apache/kudu/Schema.java File java/kudu-client/src/main/java/org/apache/kudu/Schema.java: Line 71: * Schema constructor won't check if the primary key columns are specified first I think this would be confusing for the lay user. We could either not say anything, or say that primary keys must be specified first if this Schema is used to create a table but can be anywhere if used to for a projection. -- To view, visit http://gerrit.cloudera.org:8080/5723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ca2a572801c964331ed65c630db28436fcaf86a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jun He <junhe...@gmail.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Jun He <junhe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
