Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ......................................................................
Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/5760/10/src/kudu/rpc/reactor.cc File src/kudu/rpc/reactor.cc: Line 196: void ReactorThread::AsyncHandler(ev::async& /*watcher*/, int /*revents*/) { > warning: parameter 'watcher' is unused [misc-unused-parameters] Done Line 196: void ReactorThread::AsyncHandler(ev::async& /*watcher*/, int /*revents*/) { > warning: parameter 'revents' is unused [misc-unused-parameters] Done Line 247: void ReactorThread::TimerHandler(ev::timer& /*watcher*/, int revents) { > warning: parameter 'watcher' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/5760/10/src/kudu/rpc/reactor.h File src/kudu/rpc/reactor.h: Line 97: void Run(ReactorThread* thread) override; > warning: function 'kudu::rpc::DelayedTask::Run' has a definition with diffe Done -- To view, visit http://gerrit.cloudera.org:8080/5760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I567b62f3341a1e74342c30c76b63f2ca5d7990bd Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
