Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1713: add a client Partitioner API ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5775/2/src/kudu/client/client.h File src/kudu/client/client.h: Line 2216: Status PartitionRow(const KuduPartialRow& row, int* partition); > So it's either: The second approach is still coupled to the metacache, which could be arbitrarily invalidated by other users of the same client object. That includes the possibility that the number/set of partitions could change if a range is added/dropped, which makes the 'partition number' sort of API infeasible. (even outside the possibility of concurrent changes, I'm not sure how we'd do the efficient mapping to partition numbers when going through the whole metacache shenanigans internally) -- To view, visit http://gerrit.cloudera.org:8080/5775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic08a078c75f15ef4200219b5260cfb99d79b72cc Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
