Adar Dembo has posted comments on this change. Change subject: KUDU-1853. Tablet copy: Don't orphan blocks on failure ......................................................................
Patch Set 4: (2 comments) Looks good, though the test failures look real. http://gerrit.cloudera.org:8080/#/c/5799/4/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: PS4, Line 114: Status s = Abort(); : if (PREDICT_FALSE(!s.ok())) { : LOG_WITH_PREFIX(FATAL) << "Failed to fully clean up tablet after aborted copy: " : << s.ToString(); : } Why not just WARN_NOT_OK()? Why FATAL? Line 212: // Set the data state to COPYING by default. Maybe "Set the data state to COPYING to signify that, on crash, this replica should be discarded." -- To view, visit http://gerrit.cloudera.org:8080/5799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbc0720d460de8d912a241a5186ef6e8f524b830 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
