Alexey Serbin has posted comments on this change. Change subject: [security] method to extract public part of an RSA key ......................................................................
Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/5783/11/src/kudu/master/master_cert_authority.h File src/kudu/master/master_cert_authority.h: Line 26: typedef struct rsa_st RSA; > Is this still necessary? Good catch -- will remove. http://gerrit.cloudera.org:8080/#/c/5783/13/src/kudu/security/crypto.h File src/kudu/security/crypto.h: PS13, Line 48: being at different : // inheritance branch from the PublicKey class > I think this would read better as "It's important to have PrivateKey and Pu Done -- To view, visit http://gerrit.cloudera.org:8080/5783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ac61a08c8165152d0046468c0fa655131ff8fef Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
