Alexey Serbin has posted comments on this change. Change subject: [security] avoid crashing when importing invalid TSKs ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5843/1/src/kudu/security/token-test.cc File src/kudu/security/token-test.cc: Consider adding a unit test for this update. http://gerrit.cloudera.org:8080/#/c/5843/1/src/kudu/security/token_verifier.cc File src/kudu/security/token_verifier.cc: PS1, Line 62: RuntimeError nit: does RuntimeError() seem to be the best fit compared with Corruption() and InvalidArgument() ? -- To view, visit http://gerrit.cloudera.org:8080/5843 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51dece30df0ec612417917f6855d57432fe2f7ec Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
