Hello Dan Burkert, Alexey Serbin,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5846
to look at the new patch set (#2).
Change subject: security: simplify CertSigner interface
......................................................................
security: simplify CertSigner interface
This makes CertSigner a "one-shot" type of instance, which no longer
holds long-lived references to CA certs or keys. This also removes the
'InitFromFiles()' path in CertSigner, since that's now doable directly
using the wrapper objects, and the code ended up only used by tests.
With these changes, a bunch of other things got simplified:
- no need for shared_ptr<PrivateKey> in a few places where it had leaked
- no need for multi-threading tests in cert_management-test
Change-Id: I50ee09a8bb6fba4ab6111288769b660ce61f048b
---
M src/kudu/master/master_cert_authority.cc
M src/kudu/master/master_cert_authority.h
M src/kudu/security/ca/cert_management-test.cc
M src/kudu/security/ca/cert_management.cc
M src/kudu/security/ca/cert_management.h
M src/kudu/security/crypto.cc
M src/kudu/security/crypto.h
M src/kudu/security/security-test-util.cc
M src/kudu/security/security-test-util.h
9 files changed, 117 insertions(+), 317 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/5846/2
--
To view, visit http://gerrit.cloudera.org:8080/5846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I50ee09a8bb6fba4ab6111288769b660ce61f048b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
