Alexey Serbin has posted comments on this change. Change subject: Extract a static function to generate a self-signed CA ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5844/3/src/kudu/security/security-test-util.h File src/kudu/security/security-test-util.h: PS3, Line 34: inline static Status CreateSSLServerCert May be, moving the implementation into the .cc file would be better? PS3, Line 68: inline static Status CreateSSLPrivateKey ditto -- To view, visit http://gerrit.cloudera.org:8080/5844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib40add99ed96e4753a3810709c66d07c96ab70bd Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
