Todd Lipcon has posted comments on this change. Change subject: Bump Squeasel version ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5855/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 481: ${CC:-gcc} $EXTRA_CFLAGS -std=c99 -O3 -DNDEBUG -fPIC -lcrypto -lssl -c "$SQUEASEL_SOURCE/squeasel.c" > Don't we need to do the el6 workaround dance here like we do in build_curl? I think it works without because you're just generating a static library, and so it doesn't really care about having undefined symbols, right? Same goes for the el6 workaround dance -- since it's just a static lib it doesn't pick up any paths of dependent libraries AFAIK -- To view, visit http://gerrit.cloudera.org:8080/5855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c69b412ff8f9e4c5eb1f35f86ee62e0348bf0c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
