Alexey Serbin has posted comments on this change. Change subject: [security] add channel binding to krpc ......................................................................
Patch Set 4: Code-Review+1 (4 comments) Looks good to me: just a couple of nits. I don't feel confident in SASL, so just +1. http://gerrit.cloudera.org:8080/#/c/5884/2/src/kudu/security/cert.cc File src/kudu/security/cert.cc: PS2, Line 110: > I think CRYPTO_add just returns the incremented reference count, in this ca Yep, it seems so: CRYPTO_add() returns the result ref count. http://gerrit.cloudera.org:8080/#/c/5884/3/src/kudu/security/cert.cc File src/kudu/security/cert.cc: PS3, Line 69: the multiple nit: would NotFound or NotSupported be a better fit? PS3, Line 104: f OPE style nit: consider using OPENSSL_CHECK_OK instead http://gerrit.cloudera.org:8080/#/c/5884/3/src/kudu/security/openssl_util.h File src/kudu/security/openssl_util.h: PS3, Line 27: #include "kudu/gutil/strings/substitute.h" nit: probably, this is no longer needed in this file. -- To view, visit http://gerrit.cloudera.org:8080/5884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id73fceebfcb47c881c30f6904cfd6fc6d80f50b8 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
