Adar Dembo has posted comments on this change. Change subject: [sys_catalog] make visitor's code more generic ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5901/1/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: Line 510: auto pred = ColumnPredicate::Equality(schema_.column(type_col_idx), &et); I think 'et' is just used here; how about just using entry_type directly? -- To view, visit http://gerrit.cloudera.org:8080/5901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7aa1e81ad7e61af8376ce4b52cd4020f5ce69a63 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
