Todd Lipcon has posted comments on this change. Change subject: [master] store CA information in the system table ......................................................................
Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5793/11/src/kudu/master/master_cert_authority.h File src/kudu/master/master_cert_authority.h: PS11, Line 77: // Mutex to protect access to variables below. : Mutex lock_; : > But object of this class is used to sign incoming CSRs in master_service.cc But master_service shouldn't be trying to sign anyone's CSRs until after this thing is fully initted. And once initted, the value never changes, right? i.e this should be "externally synchronized". If you put the mutex here, it would hide the TSAN warnings that might tell us if we're messing up there and starting to sign certs before it's fully ready to go. -- To view, visit http://gerrit.cloudera.org:8080/5793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16fa077e39f5d75f682cca7220371acdef4f0630 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
