Alexey Serbin has posted comments on this change.

Change subject: client: trust master's cert, adopt authn token
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5899/4/src/kudu/client/client-internal.cc
File src/kudu/client/client-internal.cc:

PS4, Line 614: for (const string& cert_der : connect_response.ca_cert_der())
So, it's possible to pass multiple CA certificates back and they are not 
supposed to form a chain, right?  So, just multiple root CA certs.

If so, consider adding a comment in the corresponding field of the protobuf 
message about that.


-- 
To view, visit http://gerrit.cloudera.org:8080/5899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa3eec178110b77d81608cfdce989e0fe494ee05
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to