Jean-Daniel Cryans has posted comments on this change. Change subject: java: use a netty frame decoder instead of replaying decoder ......................................................................
Patch Set 1: (2 comments) Good on you for addressing this. I'd be curious to see how it improves performance. http://gerrit.cloudera.org:8080/#/c/5926/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java: Line 72: I see red. http://gerrit.cloudera.org:8080/#/c/5926/1/java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java: Line 174: // TODO(todd): shouldn't this return here? Yes. -- To view, visit http://gerrit.cloudera.org:8080/5926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ec1e6f9cbbdf694fe85b7668a3c349efc26c08f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
