Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] KUDU-1643 Prune hash partitions based on IN-list predicates ......................................................................
Patch Set 7: (2 comments) Two nits and please add a comment regarding string allocations in PartitionPruner as we discussed elsewhere. http://gerrit.cloudera.org:8080/#/c/5677/7/java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java: PS7, Line 51: . nit: remove PS7, Line 488: . nit -- To view, visit http://gerrit.cloudera.org:8080/5677 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a793c23ff00d19b3d3d062bb222d2c725a93724 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Haijie Hong <honghai...@gmail.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes