Mike Percy has posted comments on this change. Change subject: KUDU-1856: always truncate containers when they get full ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5852/3/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 137: CHECK_EQ(mode, 0); > It seems we're not super consistent. Here's some greps looking at whether t Oh, interesting. I didn't ever notice that CHECK_EQ doesn't print expected vs actual, but ASSERT_EQ does. So I'd rather we be consistent across CHECK_EQ and ASSERT_EQ when possible. This is what ASSERT_EQ prints: int f = 5; ASSERT_EQ(6, f); foo-test.cc:123: Failure Value of: f Actual: 5 Expected: 6 But it's not a huge deal and we don't have to litigate this here. -- To view, visit http://gerrit.cloudera.org:8080/5852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic959c59489a08f92efa2df5c85b22e56740f1346 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
