Dan Burkert has posted comments on this change. Change subject: WIP: TLS support for Java ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5949/1/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java: Line 302: "TLS_DH_anon_WITH_AES_128_CBC_SHA")); I think it would be better if this were TLS_ECDH_anon_WITH_AES_256_CBC_SHA TLS_ECDH_anon_WITH_AES_128_CBC_SHA We could also consider adding the DH/GCM ciphers that are new in JDK 8, but I think if we have to choose between ECDH and GCM, we should choose ECDH. We should consult an expert. -- To view, visit http://gerrit.cloudera.org:8080/5949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b095ccac908f391e683ec4ef433bae52d659a21 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
