Dan Burkert has posted comments on this change. Change subject: java: implement Channel Bindings ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5953/2/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java: Line 342: throw new SSLPeerUnverifiedException("no peer cert found"); Seems easier to just throw new RuntimeException(new Sssl... than have the try/catch/propagate. -- To view, visit http://gerrit.cloudera.org:8080/5953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b604ea6a0cff55820f7fbbb3ba4beba3a888a48 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
