Todd Lipcon has posted comments on this change. Change subject: Refactor HybridClock and add a local clock mode ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5982/1/src/kudu/server/hybrid_clock.cc File src/kudu/server/hybrid_clock.cc: Line 45: DEFINE_bool(use_hybrid_clock, true, > just for internal tests and hidden + unsafe, yeah. how about --clock=system_ntp, --clock=local, --clock=logical_only? Even for internal-only usage, it's a little weird to have one flag which essentially disables the usage of the other flag. -- To view, visit http://gerrit.cloudera.org:8080/5982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78d616f64558f4b9a95535ebc8702f75a37dad39 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
