Todd Lipcon has posted comments on this change.

Change subject: rpc: move UserCredentials to separate .h/cc file
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5997/1/src/kudu/rpc/user_credentials.cc
File src/kudu/rpc/user_credentials.cc:

PS1, Line 46: // Does not print the password.
> nit: is it relevant?
just moved the code, so not going to make changes in the same patch


-- 
To view, visit http://gerrit.cloudera.org:8080/5997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I679d248e83da0aeed47957d958b0152ca4bac6cd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to