David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TIMESTAMP_NANOS type ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/5819/3/src/kudu/client/schema.h File src/kudu/client/schema.h: Line 135: TIMESTAMP_NANOS = 10 > > compilation of old user code against the new client lib would fail since well the compilation would fail since the setter would have different arguments but old compiled code switched to the new kudu shared lib would only fail at runtime, yeah. k changed the name, and removed the redirect http://gerrit.cloudera.org:8080/#/c/5819/4/src/kudu/common/key_encoder.h File src/kudu/common/key_encoder.h: Line 24: #include <string.h> > warning: #includes are not sorted properly [llvm-include-order] this goes agains our convention http://gerrit.cloudera.org:8080/#/c/5819/3/src/kudu/util/timestamp_value.cc File src/kudu/util/timestamp_value.cc: Line 128 > Maybe we should just be #defining it at the top of this file? then tidybot Done -- To view, visit http://gerrit.cloudera.org:8080/5819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63271adf6b87f048e30bf2d6d04c758884752afc Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
