Todd Lipcon has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5965/5/src/kudu/common/timestamp_value.cc File src/kudu/common/timestamp_value.cc: PS5, Line 198: if (nanos_in_day_ == TIMESTAMP_MIN_NANOS_IN_DAY) { : ss << "00:00:00"; > this is a bit surprising to me actually. So, if the time is 00:01:00 then btw checked in Impala: +----------------------------------------------------+ | cast('2017-02-14 17:34:21.000000000' as timestamp) | +----------------------------------------------------+ | 2017-02-14 17:34:21 | +----------------------------------------------------+ Fetched 1 row(s) in 0.02s [kudu-security-2:21000] > select cast('2017-02-14 17:34:21.000000001' as timestamp); Query: select cast('2017-02-14 17:34:21.000000001' as timestamp) Query submitted at: 2017-02-14 17:34:42 (Coordinator: http://kudu-security-2:25000) Query progress can be monitored at: http://kudu-security-2:25000/query_plan?query_id=2d4986dee3e82945:fb131c500000000 +----------------------------------------------------+ | cast('2017-02-14 17:34:21.000000001' as timestamp) | +----------------------------------------------------+ | 2017-02-14 17:34:21.000000001 | +----------------------------------------------------+ -- To view, visit http://gerrit.cloudera.org:8080/5965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a0763d3a28501b7f9fb0b94552e3227bd5b38cc Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
