Dan Burkert has posted comments on this change.

Change subject: [security]  security-flags
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6052/2//COMMIT_MSG
Commit Message:

PS2, Line 20: A follow up commit will hook this flag
            :     into the RPC system to ensure that authentication is enforced 
as
            :     necessary.
> keep in mind that clients don't have the ability to configure flags, so we'
Yep.


PS2, Line 42: 1) It's not strictly a server flag, it also applies to
            :     the kudu CLI tool.
> how does it apply to the CLI tool? Given that we don't currently support cl
>  I think that we should probably remove (or mark experimental/hidden) all of 
> these flags until we officially support and test the BYOPKI option)

They are marked experimental.  You are correct that BYOPKI is the only reason 
they exist, and in that case they are needed by both the servers and client.  
This is outlined in a comment in messenger.cc.


-- 
To view, visit http://gerrit.cloudera.org:8080/6052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa53348b8969e83d9f794e1e0553bdec12252d9a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to