Todd Lipcon has posted comments on this change. Change subject: [security] Add per-connection nonce for Kerberos replay resistance ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6137/3/src/kudu/security/crypto.h File src/kudu/security/crypto.h: PS3, Line 88: // Generates a nonce, and writes it to the provided slice. : Status GenerateNonce(Slice slice); > Isn't that effectively a slice? yea, but we rarely use Slice as a parameter for an output parameter like this (plus it makes the call site look pretty strange). Since we only have one use case, I think it's also reasonable to just have a 'string*' parameter and hard-code the length to 8 or 16 or whatever -- To view, visit http://gerrit.cloudera.org:8080/6137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0fb433896963be5e81d349ebf3a044a458e6627 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
