David Ribeiro Alves has posted comments on this change. Change subject: Micro-optimizations to try to inline DeltaKey::DecodeFrom ......................................................................
Patch Set 3: Code-Review+2 (1 comment) tiny nit, feel free to +2 when you fix (or if my understanding of english is wrong :) ) http://gerrit.cloudera.org:8080/#/c/6160/3/src/kudu/tablet/delta_key.h File src/kudu/tablet/delta_key.h: PS3, Line 76: is nit: it's -- To view, visit http://gerrit.cloudera.org:8080/6160 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0611a3dd1309ab815880c2d151c1270a05f8e406 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes