Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown ......................................................................
Patch Set 4: > (4 comments) > > In general I'm not a fan of the additional bool* out params, when > the callers could just check > > resp.error().code() == TabletServerErrorPB::NOT_THE_LEADER > > The bool also doesn't seem to be used in non-test code. It's used in non-test code: check the 'auto non_fatal_if_error' lambda in the catalog_manager.cc file. The idea was to check whether it's a fatal or non-fatal error for those InitCertAuthority() and InitTokenSigner() method calls. -- To view, visit http://gerrit.cloudera.org:8080/6170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I826826049e3c08a6c8345949690cbbedaea32ff8 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
