David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1905 - Allow reinserts on pk only tables ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/6258/1//COMMIT_MSG Commit Message: PS1, Line 9: ha > has Done http://gerrit.cloudera.org:8080/#/c/6258/1/src/kudu/common/row_changelist.cc File src/kudu/common/row_changelist.cc: Line 163: // Note that REINSERTs might have empty changelists when reinserting a row on a tablet that > should we just say is_update()? Done http://gerrit.cloudera.org:8080/#/c/6258/2/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: Line 237: ExpectedKeyValueRow InsertOrUpsertRow(int key, int val, > nit: missing word 'if' Done PS2, Line 242: = > typo Done PS2, Line 406: : string final_error; : if (!errors.empty()) { : > what about doing something like: Done -- To view, visit http://gerrit.cloudera.org:8080/6258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ce03378c7b97fac8ad8cb7783dec4a1b0277344 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
