Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6211 to look at the new patch set (#7). Change subject: Make ExternalDaemon::StartProcess() handle fault injection ...................................................................... Make ExternalDaemon::StartProcess() handle fault injection Occasionally starting a kudu daemon fails becuase of fault injection. We recently fixed this error manifesting as SIGPIPE, but we didn't fix the underlying cause: under load, tests doing fault injection might fail before StartProcess() completes making this method return a non-OK() status. This patch makes sure that if the exit status is an expected one (85) we still return as if starting the process had succeeded. Subsequent calls to WaitForInjectedCrash() will return Status::OK(); To make sure this works, this patch includes a test that enables a "fake" fault early in the startup process and makes sure that both WaitForInjectedCrash and StartProcess() return OK() in spite of it. Change-Id: I6046e34a321de3e324e20e3d63249e4073712447 --- M src/kudu/integration-tests/external_mini_cluster-test.cc M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/external_mini_cluster.h M src/kudu/tserver/tablet_server_main.cc 4 files changed, 38 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/6211/7 -- To view, visit http://gerrit.cloudera.org:8080/6211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6046e34a321de3e324e20e3d63249e4073712447 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org>