Dan Burkert has posted comments on this change. Change subject: KUDU-1923: rpc_encryption flag is not enforced ......................................................................
Patch Set 3: (2 comments) added security-itest which disables encryption and authentication. Disabling encryption requires disabling authentication, which is why it's in the same test. http://gerrit.cloudera.org:8080/#/c/6340/2/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: PS2, Line 144: tls_context_->has_cert() && > is this a sure thing? during startup isn't it possible that we accept some Done Line 398: tls_context_->has_signed_cert()) { > seems redundant with the above Done -- To view, visit http://gerrit.cloudera.org:8080/6340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdf17c6bb59ca4af1215376c5221a90bd1d93b64 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
