Alexey Serbin has posted comments on this change.

Change subject: [java client] fixed NPE in master RPC error handler
......................................................................


Patch Set 1:

> The minicluster options should be able to be configured
 > programaticaly on a per-test-case basis (eg check how the security
 > test does it). Then we can add a new suite which adds the
 > appropriate stress tests here. I don't think Maven profiles are the
 > way to do it (too hard to run, etc)

I found that the error happens only if master server responds with 
NOT_THE_LEADER error on ConnectToMaster RPC.  I tried different scenarios, 
injecting that errors in different master RPC calls and provoking frequent 
leader re-elections, but that does not trigger this NPE.

However, even having this NPE fixed, injecting NOT_THE_LEADER into 
ConnectoToMaster() response brings in another:
java.lang.NullPointerException
        at 
org.apache.kudu.client.AsyncKuduClient.sendRpcToTablet(AsyncKuduClient.java:737)
        at 
org.apache.kudu.client.AsyncKuduClient$2RetryTimer.run(AsyncKuduClient.java:1302)

I'm not sure that's the right way to continue here -- need to clarify on this.

-- 
To view, visit http://gerrit.cloudera.org:8080/6401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib923212db1e0931ed63b31a39f03335c701f91cc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: No

Reply via email to