Alexey Serbin has posted comments on this change. Change subject: [scanner] LOG(INFO) --> VLOG(1) on scanner expiration ......................................................................
Patch Set 5: > hrm, I'm not sure about this change. In the case that we get > "scanner not found" errors on the client, it's useful to grep the > logs and find when it expired, etc. Did you find a case where this > was extremely noisy? I did this change since I saw that 'TODO' and the metric is already updated on scanner expiration. No, I didn't find it noisy. Frankly, after some consideration I think it was rather silly to following that TODO: we recently saw that log message helped people to find out scanners were expiring. I will send a patch to return LOG(INFO) back. -- To view, visit http://gerrit.cloudera.org:8080/6416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78f0b07131aaf4dc4a2cb72bed1ce1647a201b68 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
