Mike Percy has posted comments on this change. Change subject: kudu-mapreduce: tweak poms ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6418/1//COMMIT_MSG Commit Message: Line 22: fat jar containing kudu-client and kudu-mapreduce. > kudu-client won't be shaded in kudu-mapreduce or kudu-client-tools. It is Just passing through. For the tools, as long as they aren't intended to be used as libraries, shading doesn't matter. For the kudu-mapreduce fat jar, wouldn't we want all non-public APIs to be shaded? For example, Guava should still be shaded, right? -- To view, visit http://gerrit.cloudera.org:8080/6418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I599ea9610fc3d541847b0205e959e94fb8425b2e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
