Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas ......................................................................
Patch Set 12: (5 comments) http://gerrit.cloudera.org:8080/#/c/6066/11/src/kudu/consensus/metadata.proto File src/kudu/consensus/metadata.proto: PS11, Line 93: allow_unsafe > this can go along with the naming convention for API, since I was suggestin let's go with unsafe_config_change ? http://gerrit.cloudera.org:8080/#/c/6066/12/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: PS12, Line 1597: retained_uuids unused in this patch http://gerrit.cloudera.org:8080/#/c/6066/12/src/kudu/consensus/raft_consensus_state.cc File src/kudu/consensus/raft_consensus_state.cc: PS12, Line 238: In the event of unsafe config change enforced from an external tool In the event of an unsafe config change triggered by an administrator, PS12, Line 239: config the config PS12, Line 240: tool overwrote that pending config with 'unsafe' flag. So only the config : // which has the 'unsafe' flag unset both in pending and to-be-committed state : // can go through the config equality check. How about: ... because unsafe config change allows multiple pending configs to exist. Therefore we only need to validate that 'config_to_commit' matches the pending config if the pending config does not have its 'unsafe_config_change' flag set. -- To view, visit http://gerrit.cloudera.org:8080/6066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I908d8c981df74d56dbd034e72001d379fb314700 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
