David Ribeiro Alves has posted comments on this change. Change subject: [consensus] fixed typos in consensus flags tagging ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6580/1/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: Line 54: TAG_FLAG(raft_get_node_instance_timeout_ms, hidden); > I meant line 50 makes it consensus_rpc_timeout advanced. If they wanted to honestly I forget the intent (if I ever even knew it) but IMO it makes sense to have consensus_rpc_timeout_ms as advanced and not hidden as this more likely to be tweaked than raft_get_node_instance_timeout_ms -- To view, visit http://gerrit.cloudera.org:8080/6580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39fb954313368c8f612c986ab13dd47e8c948998 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
