Alexey Serbin has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch ......................................................................
Patch Set 3: (1 comment) Just a tiny nit to improve doxygen-related documentation for the new methods. http://gerrit.cloudera.org:8080/#/c/6574/3/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: Line 119: /// Advanced/Unstable API It's possible to create an explicit doxygen member group for that. Just put these two new methods inside an construct which looks like the following: /// @name Advanced/Unstable API /// ///@{ ... your new methods with their docs ... ///@} For details please see http://www.doxygen.nl/grouping.html#memgroup ; for an example of rendered documentation (Group2): http://www.doxygen.nl/examples/memgrp/html/class_test.html There an example in src/kudu/common/partial_row.h -- To view, visit http://gerrit.cloudera.org:8080/6574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c9ad5aa7c5f45a87827352597a404241912342f Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
