Hao Hao has posted comments on this change. Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/6514/1/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: Line 145: if (!FLAGS_allow_unauthenticated_public_connections && > Instead of linking to the blog, it's probably best to reference the associa Done Line 149: Status s = RejectUntrustedPublicConnection(addr); > Hmm, good point. We really only need to be checking when SASL PLAIN is bei Done Line 685: // verified. > argh, good point. I forgot that negotiated_mech_ isn't set till later. Th Done http://gerrit.cloudera.org:8080/#/c/6514/1/src/kudu/util/net/sockaddr.cc File src/kudu/util/net/sockaddr.cc: PS1, Line 117: 0xff; > could this just be 0xff? Having an odd # of hex digits is somewhat unordin Done Line 121: return true; > The google style guide allows omitting the braces here, but I think our usu Done -- To view, visit http://gerrit.cloudera.org:8080/6514 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c3fbb5491785874c5701d6c9d866949cfac905e Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Harsh J <ha...@harshj.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
