Adar Dembo has posted comments on this change. Change subject: env: add RWFile::GetExtentMap for analyzing file extents ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6583/1/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc: PS1, Line 908: uint64_t found_offset = 0; : for (const auto& e : extents) { : if (e.second >= (fs_block_size * 3)) { : found_offset = e.first + fs_block_size; : break; : } : } : if (found_offset == 0) { : LOG(INFO) << "Couldn't find extent to split, skipping this part of the test"; : return; : } > If it's virtually impossible can we just fail and adjust later if we find a Okay. http://gerrit.cloudera.org:8080/#/c/6583/3/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc: Line 888: LOG(INFO) << "GetExtentMap() not supported, skipping test"; > nit, end sentence with colon Removed, decided to use SCOPED_TRACE() instead. http://gerrit.cloudera.org:8080/#/c/6583/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: PS1, Line 732: TRACE_EVENT1("io", "PosixRWFile::GetExtentMap", "path", filename_); > right, but for things that are done "online" no? isn't this supposed to alw No, it's not just for offline tools; in the next patch you'll see it used within the LBM at startup. Besides, I don't think we should try and draw distinctions between offline and online in util code. Usage evolves and it would be a shame for an IO heavy code path to be missing from a trace because we thought it'd be offline only in the past and forgot to update it when that changed. -- To view, visit http://gerrit.cloudera.org:8080/6583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35bd1bdb9e1a839af2ab95ea73b79217c1f4a2b3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
