Todd Lipcon has posted comments on this change. Change subject: Allow to release an rpc transfer's data ......................................................................
Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/6592/8/src/kudu/rpc/outbound_call.h File src/kudu/rpc/outbound_call.h: Line 327: Status ReleaseTransferData(uint8_t** released_data); why not make this a unique_ptr<uint8_t[]>* so that it is more explicitly transferring ownership, and ensures that the caller uses the right delete[] variant? http://gerrit.cloudera.org:8080/#/c/6592/8/src/kudu/rpc/rpc_controller.h File src/kudu/rpc/rpc_controller.h: Line 200: // Deleting 'response_buffer' must be done through "delete []". same, using unique_ptr<uint8_t[]> would ensure this -- To view, visit http://gerrit.cloudera.org:8080/6592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55c2b2d24c347ccdffc054eeb4131eaf9e82f901 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
