Dan Burkert has posted comments on this change. Change subject: Add 'ksck tserver list' tool ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6654/3/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: Line 87: using consensus::ConsensusServiceProxy; > warning: using decl 'ConsensusServiceProxy' is unused [misc-unused-using-de false positive Line 92: using master::ListTabletServersRequestPB; > warning: using decl 'ListTabletServersRequestPB' is unused [misc-unused-usi false positive Line 93: using master::ListTabletServersResponsePB;; > warning: using decl 'ListTabletServersResponsePB' is unused [misc-unused-us false positive http://gerrit.cloudera.org:8080/#/c/6654/3/src/kudu/tools/tool_action_tserver.cc File src/kudu/tools/tool_action_tserver.cc: Line 113: for (const auto& column : strings::Split(columns_flag, ",")) { > warning: the variable '__end' is copy-constructed from a const reference bu ignoring -- To view, visit http://gerrit.cloudera.org:8080/6654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I047a7675c186a02dd5d8b405431ae885159fcfee Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
