Mike Percy has posted comments on this change.

Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log 
index
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6660/2/src/kudu/consensus/log-test.cc
File src/kudu/consensus/log-test.cc:

Line 1005:   ASSERT_GT(op_id.index(), INT32_MAX);
> Should we have this in master too?
Sure, I'll submit a patch to add this to master.


-- 
To view, visit http://gerrit.cloudera.org:8080/6660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284edbde51dc50fb2f98acc83cdcc3891d37863f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes

Reply via email to