Todd Lipcon has posted comments on this change. Change subject: Slice::ToDebugString() - Add option to not ascii'ize ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6671/1//COMMIT_MSG Commit Message: Line 7: Slice::ToDebugString() - Add option to not ascii'ize instead, would it be better to just use HexDump(slice) for this use case? Or maybe add a new method? I'm not too keen on adding optional parameters to such a commonly-used function. This is also part of our public ABI so i'm not sure if we can modify the signature without breaking binary compat. -- To view, visit http://gerrit.cloudera.org:8080/6671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15ed6f5e18fa20b3dca602c0a215980b97975d05 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
