Adar Dembo has posted comments on this change. Change subject: [cmake] fixed 'latest' dir symlink on MacOS X ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6667/1//COMMIT_MSG Commit Message: PS1, Line 9: If the 'latest' symbolic link already exists, do not follow it, so the : 'latest' link is updated to point to the new src directory. Prior to : this fix, the result symlink would be created in the directory which : the 'latest' points at. Just to clarify, this part was only true for macOS, right? PS1, Line 14: Also, replaced Linux-specific '-T' option with '-n' option which is : compatible at least between BSD-style and Linux ln implementations. Hmm, ISTR someone doing this in the past but it not working for some reason. I scoured old gerrit patches but couldn't find it. Anyway, could you make sure it does the right thing even on an older el6 box? -- To view, visit http://gerrit.cloudera.org:8080/6667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica6314eb5274e853b7b39b7e6ede17305d0c646d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
