Hello Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/6676

to review the following change.

Change subject: Revert "gutil: stop supporting AMD Opteron K8"
......................................................................

Revert "gutil: stop supporting AMD Opteron K8"

This reverts commit b5004e1886eb96839ec120da582f0a06ce869db2.

This change broke the release build on el6:

../../../lib/libgutil.a(atomicops-internals-x86.cc.o): In function 
`AtomicOps_x86CPUFeaturesInit()':
<src/kudu/gutil/atomicops-internals-x86.cc>:122: multiple definition of 
`AtomicOps_Internalx86CPUFeatures'
../../../../../thirdparty/installed/uninstrumented/lib64/libtcmalloc.a(atomicops-internals-x86.o):(.bss+0x0):
 first defined here
/opt/rh/devtoolset-3/root/usr/libexec/gcc/x86_64-redhat-linux/4.9.2/ld: 
Warning: size of symbol `AtomicOps_Internalx86CPUFeatures' changed from 3 in 
../../../../../thirdparty/installed/uninstrumented/lib64/libtcmalloc.a(atomicops-internals-x86.o)
 to 2 in ../../../lib/libgutil.a(atomicops-internals-x86.cc.o)

Change-Id: I898fe74cf80b0f91f1c88700572b07e131227901
---
M src/kudu/gutil/atomicops-internals-tsan.h
M src/kudu/gutil/atomicops-internals-x86.cc
M src/kudu/gutil/atomicops-internals-x86.h
M src/kudu/util/init.cc
4 files changed, 35 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/6676/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I898fe74cf80b0f91f1c88700572b07e131227901
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>

Reply via email to