Alexey Serbin has posted comments on this change. Change subject: log-test: Add additional assert ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6674/1/src/kudu/consensus/log-test.cc File src/kudu/consensus/log-test.cc: PS1, Line 1020: INT32_MAX nit: why not to use std::numeric_limits<int32_t>::max() here as well (as it's already for assigning first_log_index it's initial value)? -- To view, visit http://gerrit.cloudera.org:8080/6674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes